-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57765/#review169413
-----------------------------------------------------------
Patch looks great!
Reviews applied: [57765]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 20, 2017, 6:20 a.m., Santhosh Kumar Shanmugham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57765/
> -----------------------------------------------------------
>
> (Updated March 20, 2017, 6:20 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-7266
> https://issues.apache.org/jira/browse/MESOS-7266
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Make the port_mapping isolator play nice with external
> components by updating and removing filters that are only
> created by Mesos. This is achieved by finding the handle
> of the tc filters and using it when updating/removing
> filters to limit the scope of the change.
>
> This change will need an updated libnl
> which has been extended to provide support for querying
> `rtnl_act` objects.
>
> Note: This change needs an update to the libnl library,
> which is being worked on here -
> https://github.com/thom311/libnl/commit/9a1a71039439e81dba4c05b81eb061d632c2e7c7
> I will update the notes when the libnl change is committed and released.
>
>
> Diffs
> -----
>
> src/linux/routing/filter/action.hpp 3e1e7016aa643fc4dbbdd0f67be471908f4573c8
> src/linux/routing/filter/basic.hpp 67d99a48a0d32b6bb573384ed9f370c6c24615f9
> src/linux/routing/filter/basic.cpp c0e0cbb38bd3e76f7f0cab03b5db674e13ec660d
> src/linux/routing/filter/icmp.hpp bc0aed0f4fc7c48f06cece14aa9ec43d7fa36bc4
> src/linux/routing/filter/icmp.cpp 68a1c3486e3fceb7110769240fbca97e3325ef31
> src/linux/routing/filter/internal.hpp dc4b8f9f97a07411ac5697cb7f04282f87507034
> src/linux/routing/filter/ip.cpp 7283008c99f3cfbd43a851cf21f7c9523639cd99
> src/slave/containerizer/mesos/isolators/network/port_mapping.cpp dfa71fb6fe867c2f34451ca9f3e7f7f62402133c
> src/tests/containerizer/routing_tests.cpp d05b3b11dc5fcd54d956990f252509865168e6b6
>
>
> Diff: https://reviews.apache.org/r/57765/diff/1/
>
>
> Testing
> -------
>
> TBD
>
>
> Thanks,
>
> Santhosh Kumar Shanmugham
>
>
|