mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 57426: Added PULL_CONTAINER_IMAGE agent API call.
Date Fri, 17 Mar 2017 16:26:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57426/#review169294
-----------------------------------------------------------




include/mesos/agent/agent.proto
Lines 179 (patched)
<https://reviews.apache.org/r/57426/#comment241648>

    A future optimization:
    
    After we have image GC, it may make sense to allow an optional time duration for retention
policy of the image, so that an image GC run right after the pull will not remove a prefetched
image



include/mesos/v1/agent/agent.proto
Lines 177 (patched)
<https://reviews.apache.org/r/57426/#comment241649>

    To confirm: this is going to be a blocking call (i.e, agent HTTP API will not return until
the image pulling finishes, successful or not).
    
    You may want to document this since image pulling could take minutes for large image.


- Zhitao Li


On March 15, 2017, 10:41 a.m., Ilya Pronin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57426/
> -----------------------------------------------------------
> 
> (Updated March 15, 2017, 10:41 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-2824
>     https://issues.apache.org/jira/browse/MESOS-2824
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> New call is intended to be used by operators for asking an agent to
> pre-fetch a container image for later use.
> 
> 
> Diffs
> -----
> 
>   include/mesos/agent/agent.proto 9bac9541acd24e1123ca5dd5925e2a1381d13b4a 
>   include/mesos/v1/agent/agent.proto ea9282cf12fbe1c2ddeaa37223e4811685263734 
>   src/slave/http.cpp 1ab6f9475af287a6ac09bc615fa466223a52c97d 
>   src/slave/slave.hpp e2de66cc5b899b8b9a9ea27cc30f19a9e8fc11fb 
>   src/slave/validation.cpp 85c43cacf1361d269c28a7fe8bd1da8615949ec8 
>   src/tests/api_tests.cpp 29ae1bcf660fb0e03af1d2192484c9ec739f3ef6 
> 
> 
> Diff: https://reviews.apache.org/r/57426/diff/2/
> 
> 
> Testing
> -------
> 
> Added `AgentAPITest.PullContainerImage` test. Ran `make check`. Verified manually by
sending a call curl.
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message