mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 57712: No need to set `agent_subsystems` for all the slave tests.
Date Fri, 17 Mar 2017 14:09:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57712/#review169284
-----------------------------------------------------------



Patch looks great!

Reviews applied: [57712]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On March 17, 2017, midnight, Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57712/
> -----------------------------------------------------------
> 
> (Updated March 17, 2017, midnight)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We do not specifically depend or test for them, and since the logic
> of moving the slave into its own cgroup is done outside of the
> `Slave` class, there is no need to set the `agent_subsystems` in
> the tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp deb48c37c14b6bfa0f665d66fe52f6eb3100e226

>   src/tests/containerizer/io_switchboard_tests.cpp a2d7c32cfaac122045204c38ed0fdc87feb0e20a

>   src/tests/containerizer/memory_pressure_tests.cpp f0463601299db6790811ce2ac624a2015bad2fcd

>   src/tests/mesos.cpp cdd9bc642402bc926f3339e4e58c877b48535521 
>   src/tests/slave_recovery_tests.cpp e6b2bdd4e385208eea7dc513421024242b9efc1c 
> 
> 
> Diff: https://reviews.apache.org/r/57712/diff/1/
> 
> 
> Testing
> -------
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message