mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Megha Sharma <mshar...@apple.com>
Subject Re: Review Request 56895: Allow agents to recover slave state post a reboot.
Date Thu, 16 Mar 2017 18:25:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56895/
-----------------------------------------------------------

(Updated March 16, 2017, 6:25 p.m.)


Review request for mesos, Neil Conway and Jiang Yan Xu.


Bugs: MESOS-6223
    https://issues.apache.org/jira/browse/MESOS-6223


Repository: mesos


Description
-------

With partition awareness, the agents are now allowed to re-register
after they have been marked Unreachable. The executors are anyway
terminated on the agent when it reboots so there is no harm in
letting the agent keep its SlaveID, re-register with the master
and reconcile the lost executors. This is a pre-requisite for
supporting persistent/restartable tasks in mesos.


Diffs (updated)
-----

  src/slave/slave.hpp e2de66cc5b899b8b9a9ea27cc30f19a9e8fc11fb 
  src/slave/slave.cpp a4f4a9ca80b726de8e07571fd6d93120947c278b 
  src/slave/state.hpp a497ce1f58fb8dc7718ee5bb10bc62dd7479efa5 
  src/slave/state.cpp f8e7cdd4df0a3c5d62d89edd11844527084f2baa 
  src/tests/slave_recovery_tests.cpp e6b2bdd4e385208eea7dc513421024242b9efc1c 


Diff: https://reviews.apache.org/r/56895/diff/3/

Changes: https://reviews.apache.org/r/56895/diff/2-3/


Testing
-------

make check


Thanks,

Megha Sharma


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message