mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 56217: Added support for general checks to default executor.
Date Thu, 16 Mar 2017 16:03:58 GMT


> On Feb. 15, 2017, 2:32 p.m., Gastón Kleiman wrote:
> > src/launcher/default_executor.cpp
> > Lines 931 (patched)
> > <https://reviews.apache.org/r/56217/diff/3/?file=1627713#file1627713line931>
> >
> >     I think that it'd be useful to also log the exit status/http status code.
> >     
> >     Maybe the best way would be to implement the `ostream::operator<<` for
`CheckStatusInfo`?

Good idea.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56217/#review165698
-----------------------------------------------------------


On Feb. 8, 2017, 4:57 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56217/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2017, 4:57 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Vinod Kone.
> 
> 
> Bugs: MESOS-6906
>     https://issues.apache.org/jira/browse/MESOS-6906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp e63cf153831088851863d0956455a024e9bc172a 
> 
> 
> Diff: https://reviews.apache.org/r/56217/diff/3/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/56218/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message