mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 57644: Implemented 'ComposingContainerizer::remove(const ContainerID&)'.
Date Wed, 15 Mar 2017 16:15:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57644/#review169023
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/composing.cpp
Lines 714 (patched)
<https://reviews.apache.org/r/57644/#comment241353>

    s/Parent/Root/


- Vinod Kone


On March 15, 2017, 2:58 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57644/
> -----------------------------------------------------------
> 
> (Updated March 15, 2017, 2:58 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Bugs: MESOS-7248
>     https://issues.apache.org/jira/browse/MESOS-7248
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See the summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/composing.hpp 292374aefbc70e4b9d8c81740656864dbada8e32 
>   src/slave/containerizer/composing.cpp 46539e4671101f9c51de563f52700e974537b472 
> 
> 
> Diff: https://reviews.apache.org/r/57644/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` in Linux + manual testing
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message