mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojiannan1...@gmail.com>
Subject Re: Review Request 57360: Replace `.get().` in favor of `->` in tests.
Date Fri, 10 Mar 2017 02:18:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57360/
-----------------------------------------------------------

(Updated March 10, 2017, 10:18 a.m.)


Review request for mesos and Benjamin Mahler.


Changes
-------

rebase


Repository: mesos


Description
-------

Instead of using `get()` to fetch data, we are inclined to use
`->` operator to direct access its methods.


Diffs (updated)
-----

  src/tests/api_tests.cpp 08ad02e3e7473dc9d66b706728a0cb1955d92d1c 
  src/tests/authentication_tests.cpp adbe03043dd75a0ebb0dadb2c0b218c77b58e900 
  src/tests/cluster.cpp 04b70831ec05f715074cd93426c3645572d866ca 
  src/tests/command_executor_tests.cpp de735c62ae4be268b3e37d636f43f120f879a624 
  src/tests/container_logger_tests.cpp 54e5b29ce0668449027bde6185e37dc8b636d8c7 
  src/tests/containerizer/appc_spec_tests.cpp 840dbde1a16c6a201a65257ff207309f53f57772 
  src/tests/containerizer/cgroups_isolator_tests.cpp 971ea47ec5d2aed5e38eecf995b70ae4b0fa14a1

  src/tests/containerizer/cgroups_tests.cpp 9aa915d80024482b267ee8c981562c473795b175 
  src/tests/containerizer/cni_isolator_tests.cpp cb893d3ef005a9cc60c40768fa669b27c4863020

  src/tests/containerizer/cpu_isolator_tests.cpp f117826d9366820fd9ef5a113bb4b3d39deeca4b

  src/tests/containerizer/docker_containerizer_tests.cpp 648453328d2f0792f7b5ba89b0351a11f6630be5

  src/tests/containerizer/docker_spec_tests.cpp 82bddd228df3db95a00eb277ff9c380039b70b1e 
  src/tests/containerizer/docker_tests.cpp 452858d508e668fe62826de5558ea332cd4279d5 
  src/tests/containerizer/docker_volume_isolator_tests.cpp 4040d36d1dbf4968f62fa593024936858f28b4df

  src/tests/containerizer/fs_tests.cpp f726fb06ac3e74f7f0d6d0310ac14eef60ae4fd9 
  src/tests/containerizer/io_switchboard_tests.cpp 9031815f5711cf940315ab3d8538aa099b356847

  src/tests/containerizer/linux_filesystem_isolator_tests.cpp 51017a3a809ed0a72ea5c986a578344fff9b3276

  src/tests/containerizer/memory_isolator_tests.cpp 388e62a9d10fc806f60d84002c10d9a072071228

  src/tests/containerizer/memory_pressure_tests.cpp ff6c2b630bf67a679060bb8afeebc85f5c23a2c5

  src/tests/containerizer/mesos_containerizer_tests.cpp 683807f38778095f31d37f5598d037ab87abb66b

  src/tests/containerizer/nested_mesos_containerizer_tests.cpp ea01fe55a28d17105157004d8cf0976202a49b7c

  src/tests/containerizer/ns_tests.cpp d6be1076a393f7959cd6ac225591c8b3aa66721d 
  src/tests/containerizer/port_mapping_tests.cpp 3e848165ace8346ead39224a46f8b85a5c4ff495

  src/tests/containerizer/provisioner_appc_tests.cpp eb6509bc56214623fe9a37cbe5227768897f102c

  src/tests/containerizer/provisioner_backend_tests.cpp ab7805f62767c6146588e3181954518d65076b40

  src/tests/containerizer/provisioner_docker_tests.cpp d1eec05dbc8dbe9ddbe21d56e6c1de0c9fa09306

  src/tests/containerizer/routing_tests.cpp e6b7eadce3eeab8f7bcb15bc1e55dff78f2a4f51 
  src/tests/containerizer/xfs_quota_tests.cpp 0fbaddd68af55c51c106962377be20afa599fb97 
  src/tests/cram_md5_authentication_tests.cpp cd8607136f963b036f6563dc0947ee0d435f5c68 
  src/tests/credentials_tests.cpp 809f8c744b7e77c9aa42eaf8fe2d9d0ac9a52b4a 
  src/tests/default_executor_tests.cpp a09ae11f5fcad949fd84e4288f46675eba2e1ea9 
  src/tests/disk_quota_tests.cpp d2dfc94c5f9875fc9ce05b1c86049f8e06730029 
  src/tests/dynamic_weights_tests.cpp 5571ab7b57059e4781671f45c6e59e7c3b0c42c9 
  src/tests/environment.cpp 4c6c8f6656b62e5d8fbd8d4e8f2d7903f71e884c 
  src/tests/exception_tests.cpp 316c329c0e6cc0aaf93c6c3ca3ab4355d7a7f2ea 
  src/tests/executor_http_api_tests.cpp 892f8f669392708968ba96e5ed22eac99ae64e18 
  src/tests/fault_tolerance_tests.cpp d6bde7fb958abd67714819d96e69598753d79333 
  src/tests/fetcher_cache_tests.cpp 85246ef610fac958c54b1655361a9b9e82c23200 
  src/tests/fetcher_tests.cpp c4854b9fe4c520efc8ea06cdb42c79c333257eb1 
  src/tests/files_tests.cpp d492adf71ecb22c433f0eba4d974e99f610b5dd3 
  src/tests/gc_tests.cpp 6b6437ca0f0fa93c389e12cf2e9b23273cf23631 
  src/tests/group_tests.cpp 193a158c4d07591584fc64b6baa41f2e90618732 
  src/tests/health_check_tests.cpp 56e90747f2c943daee675738428d8ddeeafde36d 
  src/tests/hook_tests.cpp 95dcfb6655709ea2e177b32ec522ceceeaff90a1 
  src/tests/http_authentication_tests.cpp d5fabf0058755502f19eb6385bd99a0d45419508 
  src/tests/http_fault_tolerance_tests.cpp aca2466aa42c6434004eba4a43577f961e223c6a 
  src/tests/ldd_tests.cpp 2352399c30674ecaf9535ce4289efb743a2a9e8f 
  src/tests/log_tests.cpp 72182d39aa4e9d092b829316cf7214dbe7b7e98e 
  src/tests/master_allocator_tests.cpp 0fb66e4255a71e9082f99a8bd202aec691a06939 
  src/tests/master_authorization_tests.cpp 94107d00a9f4eeac5c68b90bc010e9f78cfb3457 
  src/tests/master_contender_detector_tests.cpp 2849471471ad44bfc2724ccc072db4533ea4f2a7 
  src/tests/master_maintenance_tests.cpp 237dc03b0d954f63acc82e3d80a77fae1cad5ae4 
  src/tests/master_slave_reconciliation_tests.cpp 1c7a3d686e2f924ad14c75fcab2ccafaab6d7b81

  src/tests/master_tests.cpp cacb5566cd40ab57a9c72ad02f75e84c451d08b6 
  src/tests/master_validation_tests.cpp 11dfbc612ee2c9a39a17dc1ca9bde04eeb65b550 
  src/tests/metrics_tests.cpp 27fc35f3bc47fc2905f4ce400b1051307dcacb2e 
  src/tests/oversubscription_tests.cpp e57fcc6354b6c5bea4499094513851cd2fd358a0 
  src/tests/partition_tests.cpp 2f5c6946970c15750ade75002568184db1267ba6 
  src/tests/persistent_volume_endpoints_tests.cpp 741d62e4a80f34754436e42c6357374bcbb87e32

  src/tests/persistent_volume_tests.cpp 7ac82862363af7a33a52b8570149cf2237b3519b 
  src/tests/protobuf_io_tests.cpp 82bffb814a979eceb46531f981053495c7b2bdbc 
  src/tests/rate_limiting_tests.cpp 646848e20ecd0d4934c8b6a7001a229a3fb2935a 
  src/tests/reconciliation_tests.cpp b84a1ab3dfc8a27ccee1ce844b12c646ef2145db 
  src/tests/registrar_tests.cpp fb693ea24ae0786cdb3fc09b4cc9f47d754d4c6a 
  src/tests/registrar_zookeeper_tests.cpp a31942d2bc49821d1d9af070c92cebbe85d79a9f 
  src/tests/reservation_endpoints_tests.cpp ddf279b0177b21a7c369d6a4cb46d86cceec0f98 
  src/tests/reservation_tests.cpp 95cc9118d437a325141e09e925033604f869abb5 
  src/tests/resource_offers_tests.cpp 02fb248cc6c9c083b5492d85e8270c826ffd6d68 
  src/tests/resources_tests.cpp 2bdce3c496108a66308ab6c8484dd171cc6c019f 
  src/tests/role_tests.cpp 77f3d46a544a51ba71476e2f0735bb32758dd9e1 
  src/tests/scheduler_driver_tests.cpp 3705d13c420e1715645bdef5da6bd2b8763359f4 
  src/tests/scheduler_event_call_tests.cpp 8ea5eb802b194fc149994560cfc8a6212d351087 
  src/tests/scheduler_http_api_tests.cpp 083cc3eb2d2701e25b3d6492593ea9ce52a8978a 
  src/tests/scheduler_tests.cpp 1ff423fd5abaffc0e6a0f7fb0edc3e1d5c85fb59 
  src/tests/script.cpp deec24886526a3a8355ec7cd863ca2236fae5829 
  src/tests/slave_authorization_tests.cpp 61c44460eb79931dd77c5100eb33a31a182c1710 
  src/tests/slave_recovery_tests.cpp dc82db990b00b4d6227ab5d8fcc78c1546a52fa1 
  src/tests/slave_tests.cpp 61f4f42c88ffb18dd0428e9e73a5336314877179 
  src/tests/state_tests.cpp d200768d536820f4119d3099a60746d5a14ff02d 
  src/tests/status_update_manager_tests.cpp bfb471ff0f6938e112cf7c413fc09c40512318a2 
  src/tests/upgrade_tests.cpp baf16f8922bfa3e308f359b17233f73b14a28847 
  src/tests/utils.cpp 0a9e5a867a46795f01fcf7030f50581b5ef1341f 
  src/tests/values_tests.cpp cc17b675d5d3768685b44a1cea64264dcbca80ba 
  src/tests/zookeeper_tests.cpp 72279a3397af7fa15f6ecb3c7adb9d149439e8c8 
  src/tests/zookeeper_url_tests.cpp 2b6345fd65addcae7d2ed5cc47f1f7396017fb7e 


Diff: https://reviews.apache.org/r/57360/diff/3/

Changes: https://reviews.apache.org/r/57360/diff/2-3/


Testing
-------

`s/.get()./->/` under `src/tests/`

make check


Thanks,

Jay Guo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message