mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 56757: Added the SecretGenerator module interface.
Date Fri, 10 Mar 2017 00:17:17 GMT


> On March 10, 2017, 12:16 a.m., Vinod Kone wrote:
> > include/mesos/authentication/secret_generator.hpp
> > Lines 30 (patched)
> > <https://reviews.apache.org/r/56757/diff/4/?file=1660181#file1660181line30>
> >
> >     s/represent/represents/

Can you rephrase the last sentence as well? It's a bit hard to follow.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56757/#review168557
-----------------------------------------------------------


On March 9, 2017, 2:52 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56757/
> -----------------------------------------------------------
> 
> (Updated March 9, 2017, 2:52 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Greg Mann.
> 
> 
> Bugs: MESOS-6997
>     https://issues.apache.org/jira/browse/MESOS-6997
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This interface will be used by agents to create credentials for the
> default executor.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authentication/secret_generator.hpp PRE-CREATION 
>   include/mesos/module/secret_generator.hpp PRE-CREATION 
>   src/Makefile.am bb917c5d1b36f5106a74914fa3a864038a95e8bb 
> 
> 
> Diff: https://reviews.apache.org/r/56757/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message