mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 57386: Introduced changes to the auth protos needed for DeleteNestedContainer.
Date Thu, 09 Mar 2017 01:09:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57386/#review168389
-----------------------------------------------------------


Fix it, then Ship it!




LGTM modulo picking the right name.


include/mesos/authorizer/acls.proto
Lines 448 (patched)
<https://reviews.apache.org/r/57386/#comment240626>

    move this to #440.



include/mesos/authorizer/authorizer.proto
Lines 191 (patched)
<https://reviews.apache.org/r/57386/#comment240627>

    move this to #173


- Vinod Kone


On March 8, 2017, 11:08 a.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57386/
> -----------------------------------------------------------
> 
> (Updated March 8, 2017, 11:08 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Alexander Rojas, Jie Yu, Kevin
Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-7120
>     https://issues.apache.org/jira/browse/MESOS-7120
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced changes to the auth protos needed for DeleteNestedContainer.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/acls.proto 8389917d12f9a9a3c9b4281f48e23ade14c20528 
>   include/mesos/authorizer/authorizer.proto fdc4817ce74c45d792fc47f064f7909a83b1657d

> 
> 
> Diff: https://reviews.apache.org/r/57386/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message