mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@apache.org>
Subject Re: Review Request 56731: Fix perf-stat parsing for recent perf releases.
Date Wed, 08 Mar 2017 02:12:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56731/#review168233
-----------------------------------------------------------


Ship it!




Ship It!

- haosdent huang


On Feb. 15, 2017, 11:24 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56731/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2017, 11:24 p.m.)
> 
> 
> Review request for mesos, Mesos Reviewbot and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7049
>     https://issues.apache.org/jira/browse/MESOS-7049
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> perf-stat(1) emits additional metric aggregation and value fields since
> Linux 4.6 (see kernel tree commit 92a61f6). Since these fields are not
> needed for the Sample interface, it is ok to ignore them.
> 
> 
> Diffs
> -----
> 
>   src/linux/perf.cpp 3141e5ee9eee78e974625791f362dc345c682ebb 
>   src/tests/containerizer/perf_tests.cpp d536ecc5cb24787bc3487efb146573cd4f3ded43 
> 
> 
> Diff: https://reviews.apache.org/r/56731/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check (Fedora 25)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message