> On March 1, 2017, 8:23 p.m., Vinod Kone wrote:
> > src/checks/checker.cpp
> > Line 424 (original), 440 (patched)
> > <https://reviews.apache.org/r/56208/diff/5-7/?file=1628427#file1628427line452>
> >
> > why are we sending WEXITSTATUS and not exit code?
Because what we get from `Subprocess` is actually `pid_t`. It is unclear what the scheduler
will do with the pid.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56208/#review167557
-----------------------------------------------------------
On March 1, 2017, 12:50 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56208/
> -----------------------------------------------------------
>
> (Updated March 1, 2017, 12:50 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Vinod Kone.
>
>
> Bugs: MESOS-6906
> https://issues.apache.org/jira/browse/MESOS-6906
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add support for general checks, i.e. defined by CheckInfo, in
> checking library. A general check can be either an command or
> an HTTP request. The library performs the requested check at
> the specified interval and sends the result to the framework
> via a task status update. If the current result is the same as
> the previous result, no status update is sent.
>
>
> Diffs
> -----
>
> src/checks/checker.hpp dc293f3d3613dec716510d269829f8a6f406c277
> src/checks/checker.cpp 8716e4cc684e6c4b6b76d8ca53221be06d10b2a6
> src/checks/health_checker.hpp f1f2834b3429fb00cc49c179fa9a3de328f597b5
> src/checks/health_checker.cpp 6c97369fd9a567ba16dd92085bf142d43f71eaf1
>
>
> Diff: https://reviews.apache.org/r/56208/diff/7/
>
>
> Testing
> -------
>
> https://reviews.apache.org/r/56213/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
|