mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 57186: Added unit test for persistent volume using default executor.
Date Mon, 06 Mar 2017 19:25:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57186/#review168028
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/default_executor_tests.cpp
Lines 1522 (patched)
<https://reviews.apache.org/r/57186/#comment240034>

    // Ignore subsequent offers.



src/tests/default_executor_tests.cpp
Lines 1585-1587 (patched)
<https://reviews.apache.org/r/57186/#comment240036>

    This should be moved up to #1569 to ensure the new update is not received before the expectation
is set up.


- Vinod Kone


On March 1, 2017, 8:15 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57186/
> -----------------------------------------------------------
> 
> (Updated March 1, 2017, 8:15 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Avinash sridharan, Jie Yu, Joris Van Remoortere,
and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This unit test verifies that the task group launched in the default
> executor can access the persistent volume on the executor level by
> using 'volume/sandbox_path' isolator.
> 
> The test is parameterized as the following three cases:
> 1. posix launcher + volume/sandbox_path (symlink).
> 2. linux launcher + volume/sandbox_path (symlink).
> 3. linux launcher + filesystem/linux + volume/sandbox_path (bind mount).
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp eaf639467aaaa35b28b21bfb7e16aca5924a5a82 
> 
> 
> Diff: https://reviews.apache.org/r/57186/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message