mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 57329: Renamed `activeRoles` to `roles` in the master.
Date Mon, 06 Mar 2017 19:20:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57329/#review168027
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Mahler


On March 6, 2017, 11:45 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57329/
> -----------------------------------------------------------
> 
> (Updated March 6, 2017, 11:45 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The notion of "active" currently refers to an entity's state in regards
> to the flow of resources. For example, a framework is said to be
> "active" if it is receiving resources, and an agent is said to be
> "active" if it is sending resources. `activeRoles` however does not
> follow this notion of "active", since it simply consists of roles with
> at least one __registered__ framework, rather than __active__.
> 
> Instead, it is a list of roles that the master is keeping track of.
> We therefore opt to drop the "active" portion of this list of roles.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 37b96c07f17d3e5ba96f6eade69d86ba9e039b3d 
>   src/master/master.hpp 81320e0da3a2cd99d8dea1fbea9276296ef9e515 
>   src/master/master.cpp a15c6d8fb1f99d117eed8e9453a643ec80319a52 
>   src/master/quota_handler.cpp 3ad28e4a9363a877d0610b529a6c17fb30ece37a 
>   src/master/weights_handler.cpp d8047f2354322ec18b008afe44f507069b36a71f 
> 
> 
> Diff: https://reviews.apache.org/r/57329/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message