mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 56665: Added a URL-safe base64 implementation.
Date Fri, 03 Mar 2017 14:00:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56665/
-----------------------------------------------------------

(Updated March 3, 2017, 3 p.m.)


Review request for mesos, Alexander Rojas and Greg Mann.


Changes
-------

Addressed issues.


Bugs: MESOS-7001
    https://issues.apache.org/jira/browse/MESOS-7001


Repository: mesos


Description
-------

Base64 has many variants that use different alphabets for encoding.
"Base 64 Encoding with URL and Filename Safe Alphabet" is a variant
described in RFC 4648.


Diffs (updated)
-----

  3rdparty/stout/include/stout/base64.hpp 2ac04c4602bc919633a2a480dd2168b7aa301bd7 
  3rdparty/stout/tests/base64_tests.cpp 32e516861d44c7e3a36e1a29b4d1fe5960684e3b 


Diff: https://reviews.apache.org/r/56665/diff/4/

Changes: https://reviews.apache.org/r/56665/diff/3-4/


Testing
-------

make check


Thanks,

Jan Schlicht


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message