mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 50459: Added code to generate JNI Header files.
Date Wed, 01 Mar 2017 18:45:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50459/#review167517
-----------------------------------------------------------



Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
for reopening reviews.

- Joris Van Remoortere


On Dec. 10, 2016, 7:19 p.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50459/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2016, 7:19 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5902
>     https://issues.apache.org/jira/browse/MESOS-5902
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Created a custom command to run javah on the generated java classes
> to create the JNI headers for Java bindings.
> 'make mesos-jni-headers' creates the jni header under the directory
> <BUILD-DIR>/include/java/jni/*.h
> 
> 
> Diffs
> -----
> 
>   cmake/MesosConfigure.cmake 6a9ed9dc02f5c9a6d1fce0866f19ffeafec35cdc 
>   src/java/CMakeLists.txt PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/50459/diff/4/
> 
> 
> Testing
> -------
> 
> cmake && make mesos-jni-header
> check to see if all the headers are generated.
> <BUILD_DIR>/include/java/jni/org_apache_mesos_Log.h
> <BUILD_DIR>/include/java/jni/org_apache_mesos_Log_Entry.h
> <BUILD_DIR>/include/java/jni/org_apache_mesos_Log_OperationFailedException.h
> <BUILD_DIR>/include/java/jni/org_apache_mesos_Log_Position.h
> <BUILD_DIR>/include/java/jni/org_apache_mesos_Log_Reader.h
> <BUILD_DIR>/include/java/jni/org_apache_mesos_Log_Writer.h
> <BUILD_DIR>/include/java/jni/org_apache_mesos_Log_WriterFailedException.h
> <BUILD_DIR>/include/java/jni/org_apache_mesos_MesosExecutorDriver.h
> <BUILD_DIR>/include/java/jni/org_apache_mesos_MesosSchedulerDriver.h
> <BUILD_DIR>/include/java/jni/org_apache_mesos_state_AbstractState.h
> <BUILD_DIR>/include/java/jni/org_apache_mesos_state_AbstractState_ExpungeFuture.h
> <BUILD_DIR>/include/java/jni/org_apache_mesos_state_AbstractState_FetchFuture.h
> <BUILD_DIR>/include/java/jni/org_apache_mesos_state_AbstractState_NamesFuture.h
> <BUILD_DIR>/include/java/jni/org_apache_mesos_state_AbstractState_StoreFuture.h
> <BUILD_DIR>/include/java/jni/org_apache_mesos_state_LevelDBState.h
> <BUILD_DIR>/include/java/jni/org_apache_mesos_state_LogState.h
> <BUILD_DIR>/include/java/jni/org_apache_mesos_state_Variable.h
> <BUILD_DIR>/include/java/jni/org_apache_mesos_state_ZooKeeperState.h
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message