mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 50414: Added variables for building Java Protobuf.
Date Wed, 01 Mar 2017 18:38:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50414/#review167508
-----------------------------------------------------------



Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
for reopening reviews.

- Joris Van Remoortere


On Dec. 10, 2016, 7:18 p.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50414/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2016, 7:18 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5902
>     https://issues.apache.org/jira/browse/MESOS-5902
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added protobuf_java external project to 3rdparty.
> This will setup PROTOBUF_JAVA_ROOT at location
> <BUILD-ROOT>/3rdparty/protobuf_java-2.6.1/src/protobuf_java-2.6.1
> and also define the PROTOBUF_JAR at the location
> ${PROTOBUF_JAVA_ROOT}/java/target/protobuf-java-2.6.1.jar
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake e9eabd08d327f4c714199f7bde91b9adf644a678

> 
> 
> Diff: https://reviews.apache.org/r/50414/diff/7/
> 
> 
> Testing
> -------
> 
> cmake .. && make
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message