-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50959/#review167397
-----------------------------------------------------------
Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
for reopening reviews.
- Joris Van Remoortere
On Oct. 16, 2016, 5:58 p.m., Srinivas Brahmaroutu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50959/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2016, 5:58 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-4288
> https://issues.apache.org/jira/browse/MESOS-4288
>
>
> Repository: mesos
>
>
> Description
> -------
>
> AppcFetcherPlugin returns a '.aci' file of a container image.
>
> Fetch supports all three modes that 'rkt fetch' supports, fetch with
> meta discovery ex: 'coreos.com/hello:latest', fetch from a specific
> location ex: 'https://github.com/xxx/hello.aci' or fetch from docker
> registry ex: 'docker://hello-world'.
>
> Added new fetched plugin for Appc fetch algorithm. The new
> AppcFetcherPlugin implements two methods. Method 'rktFetch' is used to
> fetch a container image into a store specified at a directory location
> using 'rkt fetch' command and method 'rktExport' exports the image
> fetched into the directory location as a '.aci' file that is in tar
> file format, usinf 'rkt image export' command.
>
>
> Diffs
> -----
>
> src/Makefile.am 3bcc0f2dfc2c4f71841bd6d161f39e0e919fc0d7
> src/uri/fetcher.hpp 949363ecdb15f5b225db7f3ed67eda52c351bfa1
> src/uri/fetcher.cpp 904fce5a203c57ef1b8fdda09c81efbcf18f5d2c
> src/uri/fetchers/rkt.hpp PRE-CREATION
> src/uri/fetchers/rkt.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/50959/diff/6/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Srinivas Brahmaroutu
>
>
|