Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 89324200C34 for ; Mon, 27 Feb 2017 15:16:02 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 86204160B60; Mon, 27 Feb 2017 14:16:02 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CE514160B56 for ; Mon, 27 Feb 2017 15:16:01 +0100 (CET) Received: (qmail 46208 invoked by uid 500); 27 Feb 2017 14:16:00 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 46182 invoked by uid 99); 27 Feb 2017 14:16:00 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Feb 2017 14:16:00 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 42A5C31B42E; Mon, 27 Feb 2017 14:16:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2759713204460907803==" MIME-Version: 1.0 Subject: Re: Review Request 57054: Fixed a bug in master and agent handler authorization logic. From: Alexander Rojas To: Adam B , Alexander Rojas , Jan Schlicht , Vinod Kone Cc: Greg Mann , mesos Date: Mon, 27 Feb 2017 14:16:00 -0000 Message-ID: <20170227141600.23893.28371@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alexander Rojas X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57054/ X-Sender: Alexander Rojas X-ReviewBoard-ShipIt: 1 References: <20170224230605.13823.29213@reviews.apache.org> In-Reply-To: <20170224230605.13823.29213@reviews.apache.org> Reply-To: Alexander Rojas X-ReviewRequest-Repository: mesos archived-at: Mon, 27 Feb 2017 14:16:02 -0000 --===============2759713204460907803== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57054/#review166866 ----------------------------------------------------------- Ship it! Thanks for taking care of this! - Alexander Rojas On Feb. 25, 2017, 12:06 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57054/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2017, 12:06 a.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, and Vinod Kone. > > > Bugs: MESOS-7003 > https://issues.apache.org/jira/browse/MESOS-7003 > > > Repository: mesos > > > Description > ------- > > This patch fixes a bug in which endpoint handlers would not > correctly handle the case in which authorization is enabled > when authentication is disabled. In this case, the handlers > would send a default-constructed `authorization::Subject` to > the authorizer, leading to an empty-string principal being > evaluated as the subject. > > This patch updates the handlers to correctly send `NONE` as > the subject in this case. > > > Diffs > ----- > > src/master/http.cpp 6e5178eeea6cc6b90ae253840da22be13444b088 > src/slave/http.cpp 94731ec883c309cefb811694dc4e39de12d1ac59 > src/slave/slave.cpp fc480ae23ffa5cdeeb79b3621a08e1f8703bc01a > > Diff: https://reviews.apache.org/r/57054/diff/ > > > Testing > ------- > > Testing details can be found at the end of this patch chain. > > > Thanks, > > Greg Mann > > --===============2759713204460907803==--