Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============6494255669372956293=="
MIME-Version: 1.0
Subject: Re: Review Request 56939: Added allocation role validation for
 ExecutorInfo.
From: Jay Guo <guojiannan1101@gmail.com>
To: Benjamin Bannier <benjamin.bannier@mesosphere.io>,
 Benjamin Mahler <bmahler@apache.org>, Guangya Liu <gyliu@apache.org>,
 Michael Park <mpark@apache.org>
Cc: Mesos Reviewbot <reviews@mesos.apache.org>,
 Jay Guo <guojiannan1101@gmail.com>, mesos <reviews@mesos.apache.org>
Date: Fri, 24 Feb 2017 10:52:15 -0000
Message-ID: <20170224105215.1739.92591@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Jay Guo <noreply@reviews.apache.org>
References: <20170224105116.1739.21543@reviews.apache.org>
In-Reply-To: <20170224105116.1739.21543@reviews.apache.org>
Reply-To: Jay Guo <guojiannan1101@gmail.com>
archived-at: Fri, 24 Feb 2017 10:52:18 -0000

--===============6494255669372956293==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Feb. 24, 2017, 6:51 p.m., Jay Guo wrote:
> > src/master/validation.cpp, lines 590-609
> > <https://reviews.apache.org/r/56939/diff/2/?file=1646991#file1646991line590>
> >
> >     Could we leverage `Resources::allocations()` to help with mix detection? e.g.
> >     ```
> >     If (resources.allocations().size() > 1) {
> >       return Error(...);
> >     }
> >     ```
> >     
> >     In this case, `RESERVE` operation could not use this method since resources are not always allocated in case we are dealing with Operator API.

Also, should we deal with the case where some of the resources are _not_ allocated, and others are allocated to same role.


- Jay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56939/#review166680
-----------------------------------------------------------


On Feb. 24, 2017, 6:48 p.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56939/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2017, 6:48 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and Michael Park.
> 
> 
> Bugs: MESOS-6636
>     https://issues.apache.org/jira/browse/MESOS-6636
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> With support for multi-role frameworks, we need to make sure that
> individual executors cannot mix allocation roles.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.hpp f03b3280704083be1ca074ca07c69edbb49dae19 
>   src/master/validation.cpp b8c6b49ca5ca1f15e58a2967adc335436a35071f 
>   src/tests/master_validation_tests.cpp 45254739e2a62fed7008ceada7a8f64bb9ee4e31 
> 
> Diff: https://reviews.apache.org/r/56939/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


--===============6494255669372956293==--