Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7823D200C25 for ; Fri, 24 Feb 2017 11:48:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 76C2A160B69; Fri, 24 Feb 2017 10:48:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C0FC0160B5C for ; Fri, 24 Feb 2017 11:48:05 +0100 (CET) Received: (qmail 61936 invoked by uid 500); 24 Feb 2017 10:48:05 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 61906 invoked by uid 99); 24 Feb 2017 10:48:04 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Feb 2017 10:48:04 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 701033136D4; Fri, 24 Feb 2017 10:48:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3727208976512766089==" MIME-Version: 1.0 Subject: Re: Review Request 56939: Added allocation role validation for ExecutorInfo. From: Jay Guo To: Benjamin Bannier , Benjamin Mahler , Guangya Liu , Michael Park Cc: Mesos Reviewbot , Jay Guo , mesos Date: Fri, 24 Feb 2017 10:48:04 -0000 Message-ID: <20170224104804.1738.54105@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jay Guo X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/56939/ X-Sender: Jay Guo References: <20170222174351.1739.73217@reviews.apache.org> In-Reply-To: <20170222174351.1739.73217@reviews.apache.org> Reply-To: Jay Guo X-ReviewRequest-Repository: mesos archived-at: Fri, 24 Feb 2017 10:48:06 -0000 --===============3727208976512766089== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56939/ ----------------------------------------------------------- (Updated Feb. 24, 2017, 6:48 p.m.) Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and Michael Park. Summary (updated) ----------------- Added allocation role validation for ExecutorInfo. Bugs: MESOS-6636 https://issues.apache.org/jira/browse/MESOS-6636 Repository: mesos Description (updated) ------- With support for multi-role frameworks, we need to make sure that individual executors cannot mix allocation roles. Diffs (updated) ----- src/master/validation.hpp f03b3280704083be1ca074ca07c69edbb49dae19 src/master/validation.cpp b8c6b49ca5ca1f15e58a2967adc335436a35071f src/tests/master_validation_tests.cpp 45254739e2a62fed7008ceada7a8f64bb9ee4e31 Diff: https://reviews.apache.org/r/56939/diff/ Testing ------- make check Thanks, Jay Guo --===============3727208976512766089==--