Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E37AA200C23 for ; Wed, 22 Feb 2017 15:28:20 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id E2156160B67; Wed, 22 Feb 2017 14:28:20 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 36E26160B49 for ; Wed, 22 Feb 2017 15:28:20 +0100 (CET) Received: (qmail 20612 invoked by uid 500); 22 Feb 2017 14:28:19 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 20599 invoked by uid 99); 22 Feb 2017 14:28:19 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Feb 2017 14:28:19 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 08897312D04; Wed, 22 Feb 2017 14:28:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0648109739757805740==" MIME-Version: 1.0 Subject: Re: Review Request 56753: Implemented the JWT authenticator. From: Jan Schlicht To: Greg Mann Cc: Mesos Reviewbot , Jan Schlicht , mesos Date: Wed, 22 Feb 2017 14:28:19 -0000 Message-ID: <20170222142819.1739.70995@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jan Schlicht X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/56753/ X-Sender: Jan Schlicht References: <20170216140703.13057.5765@reviews.apache.org> In-Reply-To: <20170216140703.13057.5765@reviews.apache.org> X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/basic_authenticator.cpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/authenticator.cpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/jwt_authenticator.cpp Reply-To: Jan Schlicht X-ReviewRequest-Repository: mesos archived-at: Wed, 22 Feb 2017 14:28:21 -0000 --===============0648109739757805740== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56753/ ----------------------------------------------------------- (Updated Feb. 22, 2017, 3:28 p.m.) Review request for mesos and Greg Mann. Changes ------- Rebased. Bugs: MESOS-7001 https://issues.apache.org/jira/browse/MESOS-7001 Repository: mesos Description ------- This HTTP authenticator extracts a JWT from the requests' authorization header using the 'Bearer' schema and validates it against a secret using HMAC SHA256. The 'sub' claim of the JWT is the extracted principal, all other claims will be additional labels of the 'AuthenticationContext'. Diffs (updated) ----- 3rdparty/libprocess/Makefile.am 75386184108214e67a58c328258ec204099d638c 3rdparty/libprocess/include/process/authenticator.hpp e5489c6cb4adc8a822e7dd4515542618c36136f9 3rdparty/libprocess/src/authenticator.cpp cfedb6f7674e0f6690e77a633cdd1bd494c7d2c7 3rdparty/libprocess/src/jwt_authenticator.cpp PRE-CREATION 3rdparty/libprocess/src/tests/http_tests.cpp fb4da9aecff0370d97a15269c5d8fffb30e0478f Diff: https://reviews.apache.org/r/56753/diff/ Testing ------- make check Thanks, Jan Schlicht --===============0648109739757805740==--