Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5EC0A200C25 for ; Fri, 10 Feb 2017 03:32:57 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 5D33D160B64; Fri, 10 Feb 2017 02:32:57 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A7472160B50 for ; Fri, 10 Feb 2017 03:32:56 +0100 (CET) Received: (qmail 2952 invoked by uid 500); 10 Feb 2017 02:32:55 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 2939 invoked by uid 99); 10 Feb 2017 02:32:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Feb 2017 02:32:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8BE572DF898; Fri, 10 Feb 2017 02:32:54 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0469983519231487877==" MIME-Version: 1.0 Subject: Re: Review Request 56347: Stout: Explicitly delete `SharedHandle` default constructor. From: Mesos Reviewbot To: Joseph Wu , Alex Clemmer Cc: Mesos Reviewbot , mesos Date: Fri, 10 Feb 2017 02:32:54 -0000 Message-ID: <20170210023254.31773.92544@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/56347/ X-Sender: Mesos Reviewbot References: <20170206225656.31773.13984@reviews.apache.org> In-Reply-To: <20170206225656.31773.13984@reviews.apache.org> Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos archived-at: Fri, 10 Feb 2017 02:32:57 -0000 --===============0469983519231487877== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56347/#review165055 ----------------------------------------------------------- Patch looks great! Reviews applied: [56347] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Feb. 6, 2017, 10:56 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56347/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2017, 10:56 p.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Stout: Explicitly delete `SharedHandle` default constructor. > > > Diffs > ----- > > 3rdparty/stout/include/stout/windows.hpp 3bc973b88ea39948780df2ecc7c3692f7e07e1a9 > > Diff: https://reviews.apache.org/r/56347/diff/ > > > Testing > ------- > > make && make check > > > Thanks, > > Andrew Schwartzmeyer > > --===============0469983519231487877==--