Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E1EAB200C16 for ; Thu, 9 Feb 2017 08:22:18 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id E0A89160B50; Thu, 9 Feb 2017 07:22:18 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 34E84160B4C for ; Thu, 9 Feb 2017 08:22:18 +0100 (CET) Received: (qmail 340 invoked by uid 500); 9 Feb 2017 07:22:17 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 315 invoked by uid 99); 9 Feb 2017 07:22:17 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Feb 2017 07:22:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3ECB22DF8BA; Thu, 9 Feb 2017 07:22:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8620068969309416867==" MIME-Version: 1.0 Subject: Re: Review Request 55710: Added agent capabilities to /state endpoint of master. From: Jay Guo To: Benjamin Bannier , Benjamin Mahler , Guangya Liu , Michael Park Cc: Mesos Reviewbot , Jay Guo , mesos Date: Thu, 09 Feb 2017 07:22:16 -0000 Message-ID: <20170209072216.31773.63207@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jay Guo X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/55710/ X-Sender: Jay Guo References: <20170207095927.31774.86153@reviews.apache.org> In-Reply-To: <20170207095927.31774.86153@reviews.apache.org> Reply-To: Jay Guo X-ReviewRequest-Repository: mesos archived-at: Thu, 09 Feb 2017 07:22:19 -0000 --===============8620068969309416867== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55710/ ----------------------------------------------------------- (Updated Feb. 9, 2017, 3:22 p.m.) Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and Michael Park. Changes ------- address mcypark's comments. Bugs: MESOS-6902 https://issues.apache.org/jira/browse/MESOS-6902 Repository: mesos Description ------- Master should be able to reflect agent capabilities via `/state`(v0) and `getState`(v1) endpoints. Diffs (updated) ----- include/mesos/master/master.proto a2228db8902c297f137b8106a7b3d2babbc35017 include/mesos/v1/master/master.proto cfdca7400d98233c6320eebd8784e4f51c43ebbd src/common/protobuf_utils.hpp 3ba689f30ae080ea9b2a0af4d819dd3e377c7bf5 src/common/protobuf_utils.cpp ed84e9ae083c2dc6cd8b49d9ce8dc624a8607b8a src/master/http.cpp a598488296d4616c0126aa3bd4d1d7e7a6e439fe src/tests/master_tests.cpp 3b4123b49ee32c902a5d2a01fcc7026da21fdd18 Diff: https://reviews.apache.org/r/55710/diff/ Testing ------- make check GTEST_FILTER="MasterTest.StateEndpointAgentCapabilities" [ OK ] MasterTest.StateEndpointAgentCapabilities (85 ms) [----------] 1 test from MasterTest (94 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (122 ms total) make check on Ubuntu 14.04 Thanks, Jay Guo --===============8620068969309416867==--