Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9349E200C10 for ; Fri, 3 Feb 2017 13:10:25 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 91713160B62; Fri, 3 Feb 2017 12:10:25 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DF95F160B55 for ; Fri, 3 Feb 2017 13:10:24 +0100 (CET) Received: (qmail 30776 invoked by uid 500); 3 Feb 2017 12:10:24 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 30685 invoked by uid 99); 3 Feb 2017 12:10:23 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Feb 2017 12:10:23 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 990032C5B86; Fri, 3 Feb 2017 12:10:23 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1100639197683215577==" MIME-Version: 1.0 Subject: Re: Review Request 56178: Enabled the authorizer to work with MULTI_ROLE frameworks. From: Benjamin Bannier To: Adam B , Benjamin Mahler , Alexander Rojas Cc: Benjamin Bannier , Mesos Reviewbot , mesos Date: Fri, 03 Feb 2017 12:10:23 -0000 Message-ID: <20170203121023.1724.76381@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Bannier X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/56178/ X-Sender: Benjamin Bannier References: <20170201170602.1704.78910@reviews.apache.org> In-Reply-To: <20170201170602.1704.78910@reviews.apache.org> Reply-To: Benjamin Bannier X-ReviewRequest-Repository: mesos archived-at: Fri, 03 Feb 2017 12:10:25 -0000 --===============1100639197683215577== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56178/ ----------------------------------------------------------- (Updated Feb. 3, 2017, 1:10 p.m.) Review request for mesos, Adam B, Alexander Rojas, and Benjamin Mahler. Bugs: MESOS-7022 https://issues.apache.org/jira/browse/MESOS-7022 Repository: mesos Description ------- This updates the local authorizer so that MULTI_ROLE frameworks can be authorized. For non-MULTI_ROLE frameworks we continue to support use of the deprecated 'value' field in the authorization request's 'Object'; however for MULTI_ROLE frameworks the 'value' field will not be set, and authorizers still relying on it should be updated to instead use the object's 'framework_info' field to extract roles to authorize against from. Diffs (updated) ----- src/authorizer/local/authorizer.cpp b98e1fcdf2ee5ec1f6ac0be6f8accdefaa390a09 src/master/master.cpp 284566ca72bd5c6bd581db9b65d404f86aa7bf61 Diff: https://reviews.apache.org/r/56178/diff/ Testing ------- Tested on various configurations in internal CI. Thanks, Benjamin Bannier --===============1100639197683215577==--