mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 56665: Added a URL-safe base64 implementation.
Date Tue, 28 Feb 2017 22:16:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56665/#review167145
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/stout/include/stout/base64.hpp (line 32)
<https://reviews.apache.org/r/56665/#comment239317>

    I think we prefer `constexpr char` for constants like this: http://mesos.apache.org/documentation/latest/c++-style-guide/
    
    As long as you're touching this, could you change to `constexpr`?



3rdparty/stout/include/stout/base64.hpp (line 37)
<https://reviews.apache.org/r/56665/#comment239318>

    ditto



3rdparty/stout/tests/base64_tests.cpp (lines 48 - 69)
<https://reviews.apache.org/r/56665/#comment239330>

    Could we use strings for these tests that include both of the modified alphabet characters,
'-' and '_'?


- Greg Mann


On Feb. 27, 2017, 11:37 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56665/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2017, 11:37 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Greg Mann.
> 
> 
> Bugs: MESOS-7001
>     https://issues.apache.org/jira/browse/MESOS-7001
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Base64 has many variants that use different alphabets for encoding.
> "Base 64 Encoding with URL and Filename Safe Alphabet" is a variant
> described in RFC 4648.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/base64.hpp 2ac04c4602bc919633a2a480dd2168b7aa301bd7 
>   3rdparty/stout/tests/base64_tests.cpp 32e516861d44c7e3a36e1a29b4d1fe5960684e3b 
> 
> Diff: https://reviews.apache.org/r/56665/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message