mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 56813: Updated master handlers to use 'AuthenticationContext'.
Date Tue, 28 Feb 2017 13:38:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56813/#review167059
-----------------------------------------------------------




src/master/http.cpp (line 115)
<https://reviews.apache.org/r/56813/#comment239185>

    wasn't metrics process used at all?



src/master/http.cpp (lines 805 - 806)
<https://reviews.apache.org/r/56813/#comment239186>

    This can be merge into one line.



src/master/http.cpp (lines 884 - 886)
<https://reviews.apache.org/r/56813/#comment239187>

    I'm not sure printing the whole `principal` with name and claims is such a good idea.
The reason is that you only print `framework->info.principal()`, and to my knowledge, only
compare the names. Perhaps is a better idea to only print `principal->name`?



src/master/http.cpp (lines 1104 - 1106)
<https://reviews.apache.org/r/56813/#comment239188>

    This line doesn't need change.



src/master/http.cpp (lines 2203 - 2206)
<https://reviews.apache.org/r/56813/#comment239189>

    This line didn't need modification. However it does raises the issue of the signature
of `validation::operation::validate()`. The common pattern in Mesos is to use a default parameter
in the declaration, like:
    
    ```c++
    Option<Error> validate(
        const Offer::Operation::Reserve& reserve,
        const Option<string>& principal,
        const Option<FrameworkInfo>& frameworkInfo = None())
    ```
    
    so that the caller doesn't need to do it. Doing a grep on the srouce code in over a hundred
instances of that pattern.
    
    Could you quickly fix that?



src/master/master.cpp (lines 1070 - 1073)
<https://reviews.apache.org/r/56813/#comment239191>

    No need for the break and indent.



src/master/master.cpp (line 3880)
<https://reviews.apache.org/r/56813/#comment239193>

    /Option<Principal>::none()/None()/



src/master/master.cpp (line 3893)
<https://reviews.apache.org/r/56813/#comment239194>

    /Option<Principal>::none()/None()/



src/master/master.cpp (line 3919)
<https://reviews.apache.org/r/56813/#comment239195>

    /Option<Principal>::none()/None()/


- Alexander Rojas


On Feb. 28, 2017, 7:56 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56813/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 7:56 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and
Vinod Kone.
> 
> 
> Bugs: MESOS-7003
>     https://issues.apache.org/jira/browse/MESOS-7003
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the HTTP endpoint handlers in the
> master process to accept the `Principal` type instead
> of an `Option<string>& principal`.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 6e5178eeea6cc6b90ae253840da22be13444b088 
>   src/master/master.hpp 764adb18ddf09b62529c5c96f8e4dfaf7803483e 
>   src/master/master.cpp 2ef836536784d5fda23c80dc2304239b176a8942 
>   src/master/quota_handler.cpp 3ad28e4a9363a877d0610b529a6c17fb30ece37a 
>   src/master/registrar.cpp d7134eea34102ab7b24d2f0131363bdd9005cfd3 
>   src/master/weights_handler.cpp 4f6a4cd29d27b64cbc9ee6d8909f79812313b681 
> 
> Diff: https://reviews.apache.org/r/56813/diff/
> 
> 
> Testing
> -------
> 
> Testing details can be found at the end of this review chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message