mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 56611: Relax perf version check for Arch Linux.
Date Tue, 28 Feb 2017 05:43:20 GMT


On Feb. 26, 2017, 7:48 p.m., James Peach wrote:
> > Sorry, one more thing to address and then I'll commit this: on certain versions
of Ubuntu, `perf` is often installed but does not work correctly:
> > 
> > ```
> > $ perf --version
> > WARNING: perf not found for kernel 3.19.0-28
> > 
> >   You may need to install the following packages for this specific kernel:
> >     linux-tools-3.19.0-28-generic
> >     linux-cloud-tools-3.19.0-28-generic
> > 
> >   You may also want to install one of the following packages to keep up to date:
> >     linux-tools-generic
> >     linux-cloud-tools-generic
> > ```
> > 
> > On such a system, `PerfTest.Version` yields:
> > 
> > ```
> > [ RUN      ] PerfTest.Version
> > ../../mesos/src/tests/containerizer/perf_tests.cpp:134: Failure
> > (perf::version()).failure(): Failed to execute perf: exited with status 2
> > [  FAILED  ] PerfTest.Version (51 ms)
> > [----------] 1 test from PerfTest (51 ms total)
> > ```

Rather than continuing to second guess packagers and cloud vendors, I added a check that the
`perf --version` completes successfully (as opposed to perf merely being present). It feels
a bit grungy but I expect it will be reasonably reliable for testing purposes.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56611/#review166819
-----------------------------------------------------------


On Feb. 14, 2017, 3:59 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56611/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2017, 3:59 p.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-6982
>     https://issues.apache.org/jira/browse/MESOS-6982
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Relax perf version check for Arch Linux.
> 
> 
> Diffs
> -----
> 
>   src/linux/perf.hpp 9c4330b6086abb18f036222260fe89a6fb01d8ed 
>   src/linux/perf.cpp 3141e5ee9eee78e974625791f362dc345c682ebb 
>   src/tests/containerizer/perf_tests.cpp d536ecc5cb24787bc3487efb146573cd4f3ded43 
> 
> Diff: https://reviews.apache.org/r/56611/diff/
> 
> 
> Testing
> -------
> 
> make check (Fedora 25)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message