mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 57111: Updated the allocator to handle frameworks that change its roles.
Date Mon, 27 Feb 2017 22:30:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57111/#review166955
-----------------------------------------------------------




src/master/allocator/mesos/hierarchical.hpp (line 429)
<https://reviews.apache.org/r/57111/#comment239046>

    This is because when a partitioned agent comes back with a task, we need to conditionally
re-add it back. With just a count, we have no way to tell whether the framework for which
the task came back for, is already in the count or not.



src/master/allocator/mesos/hierarchical.hpp (lines 513 - 523)
<https://reviews.apache.org/r/57111/#comment239048>

    These guys tie the notion of what it means for a framework to exist in a role within the
hierarchical allocator. That is, `activeRoles`, `roleSorter`, `frameworkSorters`, `frameworkSorters.at(role)`
(if one exists), and `metrics`.
    
    If this is okay, I'll add the above blurb as a comment.



src/master/allocator/mesos/hierarchical.cpp (line 1069)
<https://reviews.apache.org/r/57111/#comment239047>

    This is way more expensive than it needs to be. There's currently not a function to test
for an empty allocation. Would it be worth adding it?


- Michael Park


On Feb. 27, 2017, 2:20 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57111/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2017, 2:20 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6627
>     https://issues.apache.org/jira/browse/MESOS-6627
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp d33306745a7287b750cb4a5242c7527369d58d65

>   src/master/allocator/mesos/hierarchical.cpp eeb44fe89d4bfd26900b11833c1182157e5c7e5c

> 
> Diff: https://reviews.apache.org/r/57111/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message