mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 56611: Relax perf version check for Arch Linux.
Date Sun, 26 Feb 2017 19:48:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56611/#review166819
-----------------------------------------------------------




src/linux/perf.cpp (line 212)
<https://reviews.apache.org/r/56611/#comment238895>

    Should be `string`, not `std::string`.


Sorry, one more thing to address and then I'll commit this: on certain versions of Ubuntu,
`perf` is often installed but does not work correctly:

```
$ perf --version
WARNING: perf not found for kernel 3.19.0-28

  You may need to install the following packages for this specific kernel:
    linux-tools-3.19.0-28-generic
    linux-cloud-tools-3.19.0-28-generic

  You may also want to install one of the following packages to keep up to date:
    linux-tools-generic
    linux-cloud-tools-generic
```

On such a system, `PerfTest.Version` yields:

```
[ RUN      ] PerfTest.Version
../../mesos/src/tests/containerizer/perf_tests.cpp:134: Failure
(perf::version()).failure(): Failed to execute perf: exited with status 2
[  FAILED  ] PerfTest.Version (51 ms)
[----------] 1 test from PerfTest (51 ms total)
```

- Neil Conway


On Feb. 14, 2017, 3:59 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56611/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2017, 3:59 p.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-6982
>     https://issues.apache.org/jira/browse/MESOS-6982
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Relax perf version check for Arch Linux.
> 
> 
> Diffs
> -----
> 
>   src/linux/perf.hpp 9c4330b6086abb18f036222260fe89a6fb01d8ed 
>   src/linux/perf.cpp 3141e5ee9eee78e974625791f362dc345c682ebb 
>   src/tests/containerizer/perf_tests.cpp d536ecc5cb24787bc3487efb146573cd4f3ded43 
> 
> Diff: https://reviews.apache.org/r/56611/diff/
> 
> 
> Testing
> -------
> 
> make check (Fedora 25)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message