mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 57032: Added allocation role validation for Create operation.
Date Fri, 24 Feb 2017 22:43:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57032/#review166766
-----------------------------------------------------------


Fix it, then Ship it!





src/master/validation.cpp (lines 1797 - 1801)
<https://reviews.apache.org/r/57032/#comment238848>

    Let's check this only if there is a framework info.
    
    Also, as a follow up we could introduce the allocation info checking much like we did
for the reserve operation. That is, ensure it's unallocated if there is no framework info.



src/master/validation.cpp (line 1800)
<https://reviews.apache.org/r/57032/#comment238849>

    No need for putting this on a new line?



src/tests/master_validation_tests.cpp (line 883)
<https://reviews.apache.org/r/57032/#comment238850>

    Should pass in the frameworkInfo here?


- Benjamin Mahler


On Feb. 24, 2017, 11:05 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57032/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2017, 11:05 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6636
>     https://issues.apache.org/jira/browse/MESOS-6636
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> With support for multi-role frameworks, we need to make sure that
> individual create operation cannot mix allocation roles.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.cpp b8c6b49ca5ca1f15e58a2967adc335436a35071f 
>   src/tests/master_validation_tests.cpp 45254739e2a62fed7008ceada7a8f64bb9ee4e31 
> 
> Diff: https://reviews.apache.org/r/57032/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message