mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojiannan1...@gmail.com>
Subject Re: Review Request 56939: Added allocation role validation for ExecutorInfo.
Date Fri, 24 Feb 2017 10:52:15 GMT


> On Feb. 24, 2017, 6:51 p.m., Jay Guo wrote:
> > src/master/validation.cpp, lines 590-609
> > <https://reviews.apache.org/r/56939/diff/2/?file=1646991#file1646991line590>
> >
> >     Could we leverage `Resources::allocations()` to help with mix detection? e.g.
> >     ```
> >     If (resources.allocations().size() > 1) {
> >       return Error(...);
> >     }
> >     ```
> >     
> >     In this case, `RESERVE` operation could not use this method since resources
are not always allocated in case we are dealing with Operator API.

Also, should we deal with the case where some of the resources are _not_ allocated, and others
are allocated to same role.


- Jay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56939/#review166680
-----------------------------------------------------------


On Feb. 24, 2017, 6:48 p.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56939/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2017, 6:48 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and Michael
Park.
> 
> 
> Bugs: MESOS-6636
>     https://issues.apache.org/jira/browse/MESOS-6636
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> With support for multi-role frameworks, we need to make sure that
> individual executors cannot mix allocation roles.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.hpp f03b3280704083be1ca074ca07c69edbb49dae19 
>   src/master/validation.cpp b8c6b49ca5ca1f15e58a2967adc335436a35071f 
>   src/tests/master_validation_tests.cpp 45254739e2a62fed7008ceada7a8f64bb9ee4e31 
> 
> Diff: https://reviews.apache.org/r/56939/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message