mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 56941: Add a test for a MULTI_ROLE master re-registering an old agent.
Date Thu, 23 Feb 2017 22:46:40 GMT


> On Feb. 23, 2017, 1:21 a.m., Benjamin Mahler wrote:
> > src/tests/master_tests.cpp, lines 6704-6705
> > <https://reviews.apache.org/r/56941/diff/1/?file=1642690#file1642690line6704>
> >
> >     Why did you need a mock executor and test containerizer? Seems to me this can
be simplified by just running a sleep task with no mocking?
> >     
> >     E.g.
> >     
> >     ```
> >     TaskInfo task = createTask(offers1.get()[0], "sleep 1000");
> >     ```
> >     
> >     You can find examples with:
> >     
> >     ```
> >     $ grep -R -i sleep src/test
> >     ```
> 
> Jay Guo wrote:
>     I'm using a `mock executor` instead of `command executor` here so that it could have
some resources, and we can inspect `allocation_info`. I'm not sure how to do that with `sleep`...

I see, ok then this sounds good.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56941/#review166458
-----------------------------------------------------------


On Feb. 23, 2017, 4:54 p.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56941/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2017, 4:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and Michael
Park.
> 
> 
> Bugs: MESOS-7063
>     https://issues.apache.org/jira/browse/MESOS-7063
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When a non-MULTI_ROLE agent with running tasks re-registers, master
> should inject allocation roles for tasks/executors sent during
> re-registration.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 89fc72b8b4757f6b7a2f090167cca49ff46cff52 
>   src/tests/upgrade_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56941/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message