mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 56711: Fixed fetcher to not pick up environment variables it should not see.
Date Mon, 20 Feb 2017 07:56:39 GMT


> On Feb. 16, 2017, 1:39 a.m., Adam B wrote:
> > src/slave/containerizer/fetcher.cpp, lines 827-828
> > <https://reviews.apache.org/r/56711/diff/1/?file=1634532#file1634532line827>
> >
> >     How confident are you that the fetcher doesn't actually need any of these env
vars? How can we test/prove it?
> 
> Till Toenshoff wrote:
>     So far I simply tried to identify such possible conflicts by looking at the code.
>     
>     The `mesos-fetcher` itself is offering support for `mesos::internal::logging::Flags`
which add the following options:
>     ```
>       add(&Flags::quiet,
>       add(&Flags::logging_level,
>       add(&Flags::log_dir,
>       add(&Flags::logbufsecs,
>       add(&Flags::initialize_driver_logging,
>       add(&Flags::external_log_file,
>     ```
>     All of the above are certainly supported by use if `MESOS_` prefixed environment
variable names. Other than that, the `mesos-fetcher` has support for `MESOS_FETCHER_INFO`
which we explicitly pass on even after that patch we are discussing here. 
>     So the things to look at should be limited towards the candidates covered by those
`Flags`. To be entirely clean we might want to consider passing those candidates through explicitly.

Well, we certainly want to support MESOS_FETCHER_INFO and the others, so let's consider blacklist/whitelist.


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56711/#review165818
-----------------------------------------------------------


On Feb. 15, 2017, 5:31 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56711/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2017, 5:31 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Bannier, and Greg Mann.
> 
> 
> Bugs: MESOS-6751 and MESOS-7133
>     https://issues.apache.org/jira/browse/MESOS-6751
>     https://issues.apache.org/jira/browse/MESOS-7133
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/fetcher.cpp 9ec38dc95dddfcd990369d0146986e20b15da1a0 
> 
> Diff: https://reviews.apache.org/r/56711/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message