mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 56375: Added a test to ensure offers with different roles cannot be combined.
Date Tue, 14 Feb 2017 00:38:25 GMT


> On Feb. 11, 2017, 12:16 a.m., Benjamin Mahler wrote:
> > src/tests/master_tests.cpp, line 2032
> > <https://reviews.apache.org/r/56375/diff/2/?file=1626156#file1626156line2032>
> >
> >     This is a little hard to figure out, can you document their allocations to describe
how we know that fair sharing will make these offers to different roles? Also, it seems to
me we don't know which of the two roles will get the initial offer?
> 
> Jay Guo wrote:
>     We could test combined offer as long as we can assert that 2nd and 3rd offers are
made to different roles, even though the role of 1st offer is not deterministic, no?

Yes that's what I imagine we want here, the part that seems unclear is how we're guaranteeing
that 2nd and 3rd offers are made to different roles. I would just suggest that we document
for posterity how we set up the test to ensure this holds.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56375/#review165041
-----------------------------------------------------------


On Feb. 13, 2017, 7:17 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56375/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2017, 7:17 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu.
> 
> 
> Bugs: MESOS-6637
>     https://issues.apache.org/jira/browse/MESOS-6637
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Multi-role framework cannot combine offers allocated to different
> roles of that framework in a single launchTask call.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 9a7a953adbbbed0b37082bb0166d03b1388c80ae 
> 
> Diff: https://reviews.apache.org/r/56375/diff/
> 
> 
> Testing
> -------
> 
> Added a test
> make check GTEST_FILTER="MasterTest.LaunchDifferentRoleLost"
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message