mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 56568: Modified the executor driver to always relink on agent failover.
Date Sat, 11 Feb 2017 12:02:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56568/#review165243
-----------------------------------------------------------



Patch looks great!

Reviews applied: [56568]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 11, 2017, 12:45 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56568/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2017, 12:45 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-7057
>     https://issues.apache.org/jira/browse/MESOS-7057
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A relink is needed in cases where a netfilter module like iptables
> can terminate the connection without notifying the executor. This
> results in the executor still trying to reuse the stale "half-open"
> connection upon receiving the reconnect message from the executor
> leading to the erroneous behavior.
> 
> 
> Diffs
> -----
> 
>   src/exec/exec.cpp 95c2e19f06c1778bd837247fc96d46d32b53c00b 
> 
> Diff: https://reviews.apache.org/r/56568/diff/
> 
> 
> Testing
> -------
> 
> Performed the steps to reproduce on MESOS-5332 and verified the problem is fixed with
the relink.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message