mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 56524: Added `drop` for overload to avoid custom logging.
Date Sat, 11 Feb 2017 01:17:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56524/#review165225
-----------------------------------------------------------


Fix it, then Ship it!





src/master/master.cpp (line 3278)
<https://reviews.apache.org/r/56524/#comment237054>

    -> instead of .get(). ?



src/master/master.cpp (line 4897)
<https://reviews.apache.org/r/56524/#comment237055>

    ditto here.


- Benjamin Mahler


On Feb. 11, 2017, 1:02 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56524/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2017, 1:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jay Guo.
> 
> 
> Bugs: MESOS-6638
>     https://issues.apache.org/jira/browse/MESOS-6638
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `drop` for overload to avoid custom logging.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 70f50f4264584be55312842b038c925687afb2cb 
>   src/master/master.cpp 80d481b2ea1435147cd213383008435f35112d92 
> 
> Diff: https://reviews.apache.org/r/56524/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message