mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 56391: Set AllocationInfo in some reservation-related tests.
Date Fri, 10 Feb 2017 02:32:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56391/#review165054
-----------------------------------------------------------




src/tests/master_validation_tests.cpp (lines 252 - 256)
<https://reviews.apache.org/r/56391/#comment236896>

    Can this just be:
    
    ```
    reserve.mutable_resources()->CopyFrom(
        allocatedResources(resource, resource.role()));
    ```
    
    Ditto below.


- Benjamin Mahler


On Feb. 8, 2017, 11:41 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56391/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2017, 11:41 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In a later change we will take a 'Resource''s 'AllocationInfo' into
> account. Update a number of tests related to resource validation to
> set 'AllocationInfo' so continue to trigger the originally expected
> errors.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_validation_tests.cpp 51185031cb67e64cd69ec6ce1c8f722a0c349970 
> 
> Diff: https://reviews.apache.org/r/56391/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message