> On Feb. 9, 2017, 9:47 a.m., Adam B wrote:
> > include/mesos/mesos.proto, line 1986
> > <https://reviews.apache.org/r/56052/diff/3/?file=1628247#file1628247line1986>
> >
> > And if key is left out, then the entire secret contents are returned/used?
That's up to the isolator module implementation - I could imagine a module which requires
`key` to be set, or one which has the behavior you describe. The example here explains the
intended semantics of these fields, but it's up to the module to consume them as it sees fit.
> On Feb. 9, 2017, 9:47 a.m., Adam B wrote:
> > include/mesos/mesos.proto, line 1994
> > <https://reviews.apache.org/r/56052/diff/3/?file=1628247#file1628247line1994>
> >
> > Why is this optional? Forward-looking for proto3?
> > I can't imagine any use for a Value secret without a value. Optional could still
be useful if we eventually decide to replace `string text` with a different type
We think it might be useful to have a `bytes` type field here as well for binary data, but
not adding it currently. I wonder if we should attempt to make a decision on that now instead
of deferring until a later date?
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56052/#review164884
-----------------------------------------------------------
On Feb. 9, 2017, 6:33 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56052/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2017, 6:33 a.m.)
>
>
> Review request for mesos, Adam B, Jie Yu, Kapil Arya, Jan Schlicht, and Vinod Kone.
>
>
> Bugs: MESOS-6996
> https://issues.apache.org/jira/browse/MESOS-6996
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a new `Secret` protobuf message which
> is designed to serve as a generic mechanism for passing
> priviledged information within Mesos.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 34a288b6f5c2fca090a7aa7a61798e3255d6663a
> include/mesos/v1/mesos.proto 6638111d10f4a36cdf91dfce1019871e9839c306
>
> Diff: https://reviews.apache.org/r/56052/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
|