mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojiannan1...@gmail.com>
Subject Re: Review Request 55710: Added agent capabilities to /state endpoint of master.
Date Thu, 09 Feb 2017 07:22:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55710/
-----------------------------------------------------------

(Updated Feb. 9, 2017, 3:22 p.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and Michael Park.


Changes
-------

address mcypark's comments.


Bugs: MESOS-6902
    https://issues.apache.org/jira/browse/MESOS-6902


Repository: mesos


Description
-------

Master should be able to reflect agent capabilities via  `/state`(v0)
and `getState`(v1) endpoints.


Diffs (updated)
-----

  include/mesos/master/master.proto a2228db8902c297f137b8106a7b3d2babbc35017 
  include/mesos/v1/master/master.proto cfdca7400d98233c6320eebd8784e4f51c43ebbd 
  src/common/protobuf_utils.hpp 3ba689f30ae080ea9b2a0af4d819dd3e377c7bf5 
  src/common/protobuf_utils.cpp ed84e9ae083c2dc6cd8b49d9ce8dc624a8607b8a 
  src/master/http.cpp a598488296d4616c0126aa3bd4d1d7e7a6e439fe 
  src/tests/master_tests.cpp 3b4123b49ee32c902a5d2a01fcc7026da21fdd18 

Diff: https://reviews.apache.org/r/55710/diff/


Testing
-------

make check GTEST_FILTER="MasterTest.StateEndpointAgentCapabilities"
[       OK ] MasterTest.StateEndpointAgentCapabilities (85 ms)
[----------] 1 test from MasterTest (94 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (122 ms total)

make check on Ubuntu 14.04


Thanks,

Jay Guo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message