mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 52284: Implemented more quota validation tests.
Date Wed, 08 Feb 2017 10:41:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52284/#review164646
-----------------------------------------------------------




src/tests/master_quota_tests.cpp (line 174)
<https://reviews.apache.org/r/52284/#comment236411>

    You could use `UNKNOWN_RULE` here to make this more self-documenting.



src/tests/master_quota_tests.cpp (line 231)
<https://reviews.apache.org/r/52284/#comment236407>

    This is not very resilent should we introduce other validation rejecting this request
for other reasons. Could you add an expectation for the response body?



src/tests/master_quota_tests.cpp (line 243)
<https://reviews.apache.org/r/52284/#comment236408>

    Please add an expectation for the response body.



src/tests/master_quota_tests.cpp (line 255)
<https://reviews.apache.org/r/52284/#comment236409>

    Please add an expectation for the response body.



src/tests/master_quota_tests.cpp (line 390)
<https://reviews.apache.org/r/52284/#comment236412>

    Should we explicitly assert here that this isn't parsed as `cpus:2;mem:512`, e.g.,
    
        ASSERT_EQ(3u, quotaResources.size());



src/tests/master_quota_tests.cpp (line 394)
<https://reviews.apache.org/r/52284/#comment236410>

    Please add an expectation for the response body.


- Benjamin Bannier


On Feb. 7, 2017, 8:10 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52284/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2017, 8:10 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Xiaojian Huang.
> 
> 
> Bugs: MESOS-4292
>     https://issues.apache.org/jira/browse/MESOS-4292
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented more quota validation tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_quota_tests.cpp b25f5911579c435549b9bc65994627414357dcb6 
> 
> Diff: https://reviews.apache.org/r/52284/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message