mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 55139: Implemented parse methods for OCI image spec.
Date Mon, 06 Feb 2017 14:41:23 GMT


> On Feb. 5, 2017, 12:02 p.m., Jie Yu wrote:
> > src/oci/spec.cpp, lines 163-166
> > <https://reviews.apache.org/r/55139/diff/3/?file=1621004#file1621004line163>
> >
> >     what if `digest.isNone()`?

`digest` is a required field, so it can not be `None()` here.


> On Feb. 5, 2017, 12:02 p.m., Jie Yu wrote:
> > src/oci/spec.cpp, lines 182-185
> > <https://reviews.apache.org/r/55139/diff/3/?file=1621004#file1621004line182>
> >
> >     What if `platform.isNone()`?

Ditto.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55139/#review164262
-----------------------------------------------------------


On Feb. 1, 2017, 9:13 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55139/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2017, 9:13 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-6681
>     https://issues.apache.org/jira/browse/MESOS-6681
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented parse methods for OCI image spec.
> 
> 
> Diffs
> -----
> 
>   include/mesos/oci/spec.hpp PRE-CREATION 
>   src/CMakeLists.txt 09ef1aee680c6b91476092dbf61d4ca3a8d256bb 
>   src/Makefile.am 6c9be54fe0ce3faaa26e2f090773d1b77bb6e430 
>   src/oci/spec.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/55139/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message