mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 55322: Used process::after instead of process::RateLimiter.
Date Thu, 02 Feb 2017 10:25:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55322/#review163954
-----------------------------------------------------------


Ship it!




This will most likely fix https://issues.apache.org/jira/browse/MESOS-7036, mind mentioning
the ticket here and updating the ticket?

Having said that, I'm curious whether we should work on a more general solution to prevent
bugs like MESOS-7036 in the future. See the example test in MESOS-7036 for more information.

- Alexander Rukletsov


On Jan. 8, 2017, 7:49 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55322/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2017, 7:49 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used process::after instead of process::RateLimiter.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp c80627986f729255e3b3ad1fc9cfa6213e19c521

> 
> Diff: https://reviews.apache.org/r/55322/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message