mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ilya Pronin <ipro...@twopensource.com>
Subject Re: Review Request 56086: Simplified AppC provisioner cache keys comparison.
Date Wed, 01 Feb 2017 18:49:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56086/
-----------------------------------------------------------

(Updated Feb. 1, 2017, 6:49 p.m.)


Review request for mesos, Benjamin Mahler and Jie Yu.


Bugs: MESOS-7046
    https://issues.apache.org/jira/browse/MESOS-7046


Repository: mesos


Description
-------

Manual elements searching is not required since `std::map` is ordered. Replaced it with standard
`operator==` that checks maps sizes and does linear element by element comparison.


Diffs
-----

  src/slave/containerizer/mesos/provisioner/appc/cache.cpp fed5ae97419d5eb9611a6fd1ade1bbed7ed440a2


Diff: https://reviews.apache.org/r/56086/diff/


Testing
-------

`make check`


Thanks,

Ilya Pronin


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message