Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 44942200C1B for ; Tue, 31 Jan 2017 02:41:31 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 43259160B60; Tue, 31 Jan 2017 01:41:31 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8E6BC160B4D for ; Tue, 31 Jan 2017 02:41:30 +0100 (CET) Received: (qmail 54069 invoked by uid 500); 31 Jan 2017 01:41:29 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 54040 invoked by uid 99); 31 Jan 2017 01:41:29 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Jan 2017 01:41:29 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8709B3198FF; Tue, 31 Jan 2017 01:41:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5988587419239043987==" MIME-Version: 1.0 Subject: Re: Review Request 51027: Track allocation candidates to bound allocator. From: Jacob Janco To: Jiang Yan Xu , Klaus Ma , Benjamin Mahler , James Peach , Guangya Liu Cc: Mesos Reviewbot , Klaus Ma , Jacob Janco , Alexander Rukletsov , mesos Date: Tue, 31 Jan 2017 01:41:27 -0000 Message-ID: <20170131014127.5717.83282@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jacob Janco X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/51027/ X-Sender: Jacob Janco References: <20170127023327.13409.39110@reviews.apache.org> In-Reply-To: <20170127023327.13409.39110@reviews.apache.org> Reply-To: Jacob Janco X-ReviewRequest-Repository: mesos archived-at: Tue, 31 Jan 2017 01:41:31 -0000 --===============5988587419239043987== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ ----------------------------------------------------------- (Updated Jan. 31, 2017, 1:41 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, James Peach, Klaus Ma, and Jiang Yan Xu. Changes ------- Rebase. Bugs: MESOS-6904 https://issues.apache.org/jira/browse/MESOS-6904 Repository: mesos Description ------- - Triggered allocations dispatch allocate() only if there is no pending allocation in the queue. - Allocation candidates are accumulated and only cleared when enqueued allocations are processed. Diffs (updated) ----- src/master/allocator/mesos/hierarchical.hpp 2cda3e311ce339d82065d68de83e86439fa192ff src/master/allocator/mesos/hierarchical.cpp f471b6848bebae601a7a0509e9c6ad5eab4fa4a2 Diff: https://reviews.apache.org/r/51027/diff/ Testing ------- make check with the filters below Broken tests: - TEST_F(HierarchicalAllocatorTest, SuppressAndReviveOffers), fix in 51028 - TEST_F(HierarchicalAllocatorTest, AllocationRunsMetric), fix in 51028 - TEST_F(HierarchicalAllocatorTest, AllocationRunTimerMetrics), fix in 51028 - TEST_F(HierarchicalAllocatorTest, UpdateWeight), fix in 51028 - TEST_P(HierarchicalAllocator_BENCHMARK_Test, AddAndUpdateSlave), fix in 51028 - TEST_F(HierarchicalAllocatorTest, SmallOfferFilterTimeout), fix in 52534 - TEST_F(OversubscriptionTest, RescindRevocableOfferWithIncreasedRevocable), fix in 51621 Thanks, Jacob Janco --===============5988587419239043987==--