Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9AAD3200C1B for ; Tue, 31 Jan 2017 01:08:49 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 92C9D160B60; Tue, 31 Jan 2017 00:08:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DE01E160B4D for ; Tue, 31 Jan 2017 01:08:48 +0100 (CET) Received: (qmail 37378 invoked by uid 500); 31 Jan 2017 00:08:48 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 37362 invoked by uid 99); 31 Jan 2017 00:08:47 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Jan 2017 00:08:47 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E412E315539; Tue, 31 Jan 2017 00:08:45 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1938981423176554099==" MIME-Version: 1.0 Subject: Re: Review Request 55852: Fixed MasterAllocatorTest/1.RebalancedForUpdatedWeights. From: Jacob Janco To: Jacob Janco , Guangya Liu Cc: Mesos Reviewbot , Jiang Yan Xu , mesos Date: Tue, 31 Jan 2017 00:08:45 -0000 Message-ID: <20170131000845.5716.81868@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jacob Janco X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/55852/ X-Sender: Jacob Janco References: <20170130235114.5716.68898@reviews.apache.org> In-Reply-To: <20170130235114.5716.68898@reviews.apache.org> Reply-To: Jacob Janco X-ReviewRequest-Repository: mesos archived-at: Tue, 31 Jan 2017 00:08:49 -0000 --===============1938981423176554099== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Jan. 30, 2017, 11:51 p.m., Jacob Janco wrote: > > Ship It! > > Jacob Janco wrote: > Makes sense, with batched allocation recovery and allocation can be interleaved causing flakiness in this test. Passed --gtest_repeat=1000 - Jacob ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55852/#review163594 ----------------------------------------------------------- On Jan. 23, 2017, 7:08 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55852/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2017, 7:08 p.m.) > > > Review request for mesos, Guangya Liu and Jacob Janco. > > > Bugs: MESOS-6904 > https://issues.apache.org/jira/browse/MESOS-6904 > > > Repository: mesos > > > Description > ------- > > - This test is broken by the batched allocation change. > > > Diffs > ----- > > src/tests/master_allocator_tests.cpp 996762f25453f7a8a5e0b7b97006ee2a603cf8c4 > > Diff: https://reviews.apache.org/r/55852/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > > --===============1938981423176554099==--