Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 658E1200C0B for ; Sun, 29 Jan 2017 15:56:26 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 643C6160B4F; Sun, 29 Jan 2017 14:56:26 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id ADBF8160B36 for ; Sun, 29 Jan 2017 15:56:25 +0100 (CET) Received: (qmail 89607 invoked by uid 500); 29 Jan 2017 14:56:25 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 89585 invoked by uid 99); 29 Jan 2017 14:56:24 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 29 Jan 2017 14:56:24 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D2C0D31915A; Sun, 29 Jan 2017 14:56:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3835000938920546959==" MIME-Version: 1.0 Subject: Re: Review Request 48291: Use varint comparator in replica log. From: Tomasz Janiszewski To: Benjamin Mahler , haosdent huang , Bing Li , Zhiwei Chen Cc: Mesos Reviewbot , Tomasz Janiszewski , mesos Date: Sun, 29 Jan 2017 14:56:22 -0000 Message-ID: <20170129145622.5717.35694@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Tomasz Janiszewski X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/48291/ X-Sender: Tomasz Janiszewski References: <20170129145436.5716.94824@reviews.apache.org> In-Reply-To: <20170129145436.5716.94824@reviews.apache.org> Reply-To: Tomasz Janiszewski X-ReviewRequest-Repository: mesos archived-at: Sun, 29 Jan 2017 14:56:26 -0000 --===============3835000938920546959== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48291/ ----------------------------------------------------------- (Updated Jan. 29, 2017, 2:56 p.m.) Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent huang. Changes ------- rebase Bugs: MESOS-970 https://issues.apache.org/jira/browse/MESOS-970 Repository: mesos Description ------- Since bug discussed at https://groups.google.com/forum/#!topic/leveldb/F-rDkWiQm6c was fixed. After upgrading leveldb to 1.18 we could replace default byte-wise comparator with varint comparator. Diffs (updated) ----- src/log/leveldb.cpp 5310a123b0fb25f240429722b676fe46174cb2ce Diff: https://reviews.apache.org/r/48291/diff/ Testing ------- `make check dist` on Ubuntu x64 Thanks, Tomasz Janiszewski --===============3835000938920546959==--