Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DF6F6200C09 for ; Wed, 25 Jan 2017 17:41:31 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id DE0AF160B3D; Wed, 25 Jan 2017 16:41:31 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 34C55160B4E for ; Wed, 25 Jan 2017 17:41:31 +0100 (CET) Received: (qmail 72660 invoked by uid 500); 25 Jan 2017 16:41:25 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 72631 invoked by uid 99); 25 Jan 2017 16:41:25 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Jan 2017 16:41:25 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7CE34317382; Wed, 25 Jan 2017 16:41:23 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4367350423669256881==" MIME-Version: 1.0 Subject: Re: Review Request 53998: Fixed hook to allow for executor environment modifications. From: Adam B To: Kapil Arya , Jie Yu , Adam B , Joseph Wu Cc: Till Toenshoff , mesos Date: Wed, 25 Jan 2017 16:41:23 -0000 Message-ID: <20170125164123.13408.94493@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Adam B X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53998/ X-Sender: Adam B References: <20161122202658.27387.65150@reviews.apache.org> In-Reply-To: <20161122202658.27387.65150@reviews.apache.org> Reply-To: Adam B X-ReviewRequest-Repository: mesos archived-at: Wed, 25 Jan 2017 16:41:32 -0000 --===============4367350423669256881== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53998/#review162967 ----------------------------------------------------------- Ping. Do we still need this? - Adam B On Nov. 22, 2016, 12:26 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53998/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2016, 12:26 p.m.) > > > Review request for mesos, Adam B, Jie Yu, Kapil Arya, and Joseph Wu. > > > Bugs: MESOS-6396 > https://issues.apache.org/jira/browse/MESOS-6396 > > > Repository: mesos > > > Description > ------- > > When being used on a task run by a command executor, the hook > `slavePreLaunchDockerEnvironmentDecorator` did not allow for extending > the executor's own environment but only the environment of the task. > By using the hook returned environment for the executor in any case > and supplying a task specific environment for the command executor, > that limitation is fixed. > > > Diffs > ----- > > src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c > > Diff: https://reviews.apache.org/r/53998/diff/ > > > Testing > ------- > > make check > > * WIP - functional testing pending - WIP * > > > Thanks, > > Till Toenshoff > > --===============4367350423669256881==--