Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 89A7B200C03 for ; Sat, 21 Jan 2017 20:49:15 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 88406160B4A; Sat, 21 Jan 2017 19:49:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F3DC7160B42 for ; Sat, 21 Jan 2017 20:49:14 +0100 (CET) Received: (qmail 12093 invoked by uid 500); 21 Jan 2017 19:49:14 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 12074 invoked by uid 99); 21 Jan 2017 19:49:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 21 Jan 2017 19:49:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C37D8315FBF; Sat, 21 Jan 2017 19:49:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7463143968106892939==" MIME-Version: 1.0 Subject: Re: Review Request 55475: Added `Master::isRemovable(const TaskState&)`. From: Neil Conway To: Vinod Kone Cc: Neil Conway , mesos Date: Sat, 21 Jan 2017 19:49:12 -0000 Message-ID: <20170121194912.28415.71180@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Neil Conway X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/55475/ X-Sender: Neil Conway References: <20170112225314.25657.7245@reviews.apache.org> In-Reply-To: <20170112225314.25657.7245@reviews.apache.org> Reply-To: Neil Conway X-ReviewRequest-Repository: mesos archived-at: Sat, 21 Jan 2017 19:49:15 -0000 --===============7463143968106892939== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55475/ ----------------------------------------------------------- (Updated Jan. 21, 2017, 7:49 p.m.) Review request for mesos and Vinod Kone. Changes ------- Rebase. Bugs: MESOS-6619 https://issues.apache.org/jira/browse/MESOS-6619 Repository: mesos Description ------- This determines whether a task in the given state can safely be discarded from the master's in-memory state. When a task becomes removable, we move the task from the master's main task data structures to a fixed-size cache (either the "unreachable" or "completed" task list, as appropriate). Diffs (updated) ----- src/master/master.hpp 8e8a9037af11cf95961b6498540a0fd486ed091b src/master/master.cpp 73159328ce3fd838e02eba0e6a30cf69efc319ba Diff: https://reviews.apache.org/r/55475/diff/ Testing ------- `make check` Thanks, Neil Conway --===============7463143968106892939==--