Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6EE26200C01 for ; Thu, 19 Jan 2017 11:14:30 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 4F2FC160B59; Thu, 19 Jan 2017 10:14:30 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 972C6160B42 for ; Thu, 19 Jan 2017 11:14:29 +0100 (CET) Received: (qmail 50291 invoked by uid 500); 19 Jan 2017 10:14:28 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 50266 invoked by uid 99); 19 Jan 2017 10:14:28 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Jan 2017 10:14:28 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9FDC2315AF2; Thu, 19 Jan 2017 10:14:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0006882769713118483==" MIME-Version: 1.0 Subject: Re: Review Request 55676: Moved `getRootContainerId` to `protobuf_utils`. From: Alexander Rojas To: Adam B , haosdent huang , Alexander Rojas , Vinod Kone , Alexander Rukletsov , Anand Mazumdar Cc: =?utf-8?q?Gast=C3=B3n_Kleiman?= , mesos Date: Thu, 19 Jan 2017 10:14:27 -0000 Message-ID: <20170119101427.28415.12636@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alexander Rojas X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/55676/ X-Sender: Alexander Rojas References: <20170118190110.28415.54280@reviews.apache.org> In-Reply-To: <20170118190110.28415.54280@reviews.apache.org> Reply-To: Alexander Rojas X-ReviewRequest-Repository: mesos archived-at: Thu, 19 Jan 2017 10:14:30 -0000 --===============0006882769713118483== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55676/#review162266 ----------------------------------------------------------- src/slave/slave.cpp Rebase problem? src/tests/slave_recovery_tests.cpp Rebase problem? - Alexander Rojas On Jan. 18, 2017, 8:01 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55676/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2017, 8:01 p.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Anand Mazumdar, Alexander Rojas, haosdent huang, and Vinod Kone. > > > Bugs: MESOS-6864 > https://issues.apache.org/jira/browse/MESOS-6864 > > > Repository: mesos > > > Description > ------- > > This method is pretty generic and should not be a part of the Mesos > containerizer code. > > > Diffs > ----- > > CHANGELOG a8d080555a3948c796116af90c17dd71e1dea5d2 > src/common/protobuf_utils.hpp bca9ace6cb37047bb08466c4fb14028bbb818446 > src/common/protobuf_utils.cpp af3c2a660f91c366ca5ffe8671d10c4a270bbbcc > src/slave/containerizer/composing.cpp 4fb7ba5cadd36be00be61aa00a69c38c44649aee > src/slave/containerizer/mesos/containerizer.cpp 8bf8a7774a38131c53f6d91c7f09f5dedd9d4cb4 > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp b3a269535517222a1d85d8be1fdf5b865d6a3fc6 > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp e1cac954848e618a03ddb82fd6d040ae1d948e82 > src/slave/containerizer/mesos/utils.hpp a54106dc4893bb222f42ede936ac9029e817faf9 > src/slave/containerizer/mesos/utils.cpp 4e2a01495909c07f320af416ff4dc59f7328c710 > src/slave/slave.cpp 205138add7a63289ff8ed81138f8b603828c748e > src/tests/slave_recovery_tests.cpp 9cf1d461cf5c6ac1f51ac963360a17e37f558505 > > Diff: https://reviews.apache.org/r/55676/diff/ > > > Testing > ------- > > `make check` in macOS and Linux. > > > Thanks, > > Gastón Kleiman > > --===============0006882769713118483==--