Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E53F4200C0E for ; Wed, 18 Jan 2017 02:50:12 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id E400D160B52; Wed, 18 Jan 2017 01:50:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2EFAF160B46 for ; Wed, 18 Jan 2017 02:50:12 +0100 (CET) Received: (qmail 87545 invoked by uid 500); 18 Jan 2017 01:50:11 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 87531 invoked by uid 99); 18 Jan 2017 01:50:11 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Jan 2017 01:50:11 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6B3EC3152EB; Wed, 18 Jan 2017 01:50:10 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2500287279581478812==" MIME-Version: 1.0 Subject: Re: Review Request 55311: Added `process::initialize` to default executor's `main`. From: Joseph Wu To: Daniel Pravat , Joseph Wu Cc: mesos , Alex Clemmer Date: Wed, 18 Jan 2017 01:50:10 -0000 Message-ID: <20170118015010.28414.58199@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Joseph Wu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/55311/ X-Sender: Joseph Wu References: <20170108062843.19097.94285@reviews.apache.org> In-Reply-To: <20170108062843.19097.94285@reviews.apache.org> Reply-To: Joseph Wu X-ReviewRequest-Repository: mesos archived-at: Wed, 18 Jan 2017 01:50:13 -0000 --===============2500287279581478812== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55311/#review162013 ----------------------------------------------------------- src/launcher/default_executor.cpp (line 1055) It actually feels like `process::Winsock winsock;` is more appropriate here, as we want the socket stack to be cleaned up afterwards as well. Either than, or you should add a `process::finalize(true)` befow. - Joseph Wu On Jan. 7, 2017, 10:28 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55311/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2017, 10:28 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > The default executor's `main` currently depends on `UPID`, which > networking libraries to do things like retrieve the address of the > current host. On Windows, this means that it is required to initialize > the winsock stack to be initialized before `UPID` is used. > > To resolve this issue, we add a call to `process::initialize` at the > beginning of the `main`, which will cause the stack to be initialized > correctly. > > > Diffs > ----- > > src/launcher/default_executor.cpp fd9963996c82461b60888397989e309d51b60aaa > > Diff: https://reviews.apache.org/r/55311/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > > --===============2500287279581478812==--